Conversation
adamjohnwright
left a comment
There was a problem hiding this comment.
This one looks good, too. My only comment is that I have not maintained the spacing correctly by changing Jenkins files in the Jenkins GUI and in the GitHub GUI. Somehow it gets messed up in the browser. I noticed that you are changing where there are all spaces to tabs. I am happy with your default setting, but if there is a way in the repository to specify, for example, a certain number of spaces per tab and then check that all relevant files are formatted that way, that would be great. Probably shouldn't do it today, but something we could think about adding in the future.
@adamjohnwright Thanks! I'm not committed to using spaces over tabs or vice-versa. As long as we're consistent. After doing some research, we could use a ".editorconfig" file (https://editorconfig.org/) for our repos then enact it using a repo-wide formatter and CI rules to apply and enforce the rules in commits. |
adds code to verify a correct run of the "download-directory" release step
Also: